Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added .VSCode settings for applying DSC PSSA rules - Fixes #189 #190

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Added .VSCode settings for applying DSC PSSA rules - Fixes #189 #190

merged 1 commit into from
Oct 2, 2018

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Oct 2, 2018 •
edited by joeyaiello
Loading

Pull Request (PR) description

This PR adds .VSCode settings for applying DSC PSSA rules.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in the resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - would you mind reviewing?

This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Oct 2, 2018
@PlagueHO PlagueHO requested a review from johlju October 2, 2018 08:23
@codecov-io
Copy link

Codecov Report

Merging #190 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@        Coverage Diff         @@
##           dev   #190   +/-   ##
==================================
  Coverage   90%    90%           
==================================
  Files        7      7           
  Lines      739    739           
==================================
  Hits       671    671           
  Misses      68     68

johlju
johlju approved these changes Oct 2, 2018
View reviewed changes
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@PlagueHO PlagueHO merged commit b41ef83 into dsccommunity:dev Oct 2, 2018
@johlju johlju removed the needs review The pull request needs a code review. label Oct 2, 2018
@PlagueHO PlagueHO deleted the Issue-189 branch October 2, 2018 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johlju johlju johlju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add .VSCode Settings for PSScriptAnalyzer Rules
3 participants
@PlagueHO @codecov-io @johlju